Skip to content

Fix build #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2019
Merged

Fix build #90

merged 1 commit into from
Apr 3, 2019

Conversation

JuanitoFatas
Copy link
Contributor

@JuanitoFatas JuanitoFatas commented Apr 2, 2019 •
edited
Loading

Update the tests for Nokogiri > 1.9.1 to fix the build.

Skip some tests for Ruby 2.2.x because Nokogiri > 1.9.1 dropped support for Ruby 2.2.

@JuanitoFatas JuanitoFatas marked this pull request as ready for review April 2, 2019 04:57
@JuanitoFatas JuanitoFatas changed the title Use correct Nokogiri versions for different Ruby versions Fix build Apr 2, 2019
@JuanitoFatas JuanitoFatas mentioned this pull request Apr 2, 2019
Merged
Update test behavior for Nokogiri > 1.9.1.
3ca8a87 
Skip some tests for Ruby 2.2 because Nokogiri behavior changed.
@JuanitoFatas
Copy link
Contributor Author

Please review @kaspth 🙏

@kaspth kaspth merged commit 5b73a09 into rails:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JuanitoFatas @kaspth